[Spice-devel] [PATCH spice-gtk 6/6] usbredir: Add awareness of host/guest side filtering
Marc-André Lureau
marcandre.lureau at gmail.com
Wed Feb 22 06:28:36 PST 2012
Hi
On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> + spice_usbredir_channel_get_guest_filter(
> + g_ptr_array_index(priv->channels, 0),
> + &guest_filter_rules, &guest_filter_rules_count);
Memory management of guest_filter_rules isn't explicit here, but
looking at usbredir code it looks like we are not leaking at least.
Shouldn't the get_guest_filter() function take a "const struct
usbredirfilter_rule **"? Or "const struct usbredirfilter_rule * const
*".. Argh C..
--
Marc-André Lureau
More information about the Spice-devel
mailing list