[Spice-devel] [PATCH spice-gtk 6/6] usbredir: Add awareness of host/guest side filtering

[Hans de Goede]

On 02/22/2012 03:28 PM, Marc-André Lureau wrote:
> Hi
>
> On Tue, Feb 21, 2012 at 3:12 PM, Hans de Goede<hdegoede at redhat.com>  wrote:
>> +    spice_usbredir_channel_get_guest_filter(
>> +        g_ptr_array_index(priv->channels, 0),
>> +&guest_filter_rules,&guest_filter_rules_count);
>
> Memory management of guest_filter_rules isn't explicit here, but
> looking at usbredir code it looks like we are not leaking at least.
>
> Shouldn't the get_guest_filter() function take a "const struct
> usbredirfilter_rule **"?

Good one, I've fixed this now, note that this required some usbredir
changes too. Luckily I had not done the new usbredir release yet. I've
just pushed usbredir-0.4 to git and it has the necessary changes
(adding a const to some usbredir prototypes).

Regards,

Hans