[Spice-devel] xpi, spicec, remote-viewer & update-alternatives

[David Jaša]

Daniel P. Berrange píše v Čt 23. 02. 2012 v 14:50 +0000:
> On Thu, Feb 23, 2012 at 03:38:28PM +0100, David Jaša wrote:
> > Hi,
> > 
> > there is a problem with running the controller driven clients:
> > 
> >       * spice-xpi doesn't pass any option to spice-xpi-client symlink
> >       * remote-viewer expects --spice-controller option
> 
> This shouldn't be any problem, as the spice-xpi-client alternative
> is not pointing directly at /usr/bin/remote-viewer. Instead it
> points to /usr/libexec/spice-xpi-client-remote-viewer.  This wrapper
> script does *not* expect any option, and will automatically add in
> --spice-controller before invoking remote-viewer.

Ah, thanks for pointer. I updated virt-viewer, created analogous script
for spicec and now the switching works for me without any more changes
needed.

David

> 
> >       * spicec expects --controller option
> >       * spice-xpi doesn't know which client is target of
> >         spice-xpi-client symlink
> > 
> > The result is that current xpi can not run any client. I can see two
> > possibilites of getting this working again:
> > 
> >       * remote-viewer's --spice-controller option will change to
> >         --controller, spice-xpi will always run spice-xpi-client with
> >         --controller option
> >       * some magic is added to XPI to recognize client to which
> >         spice-xpi-client symlink points to and based on that, decide if
> >         it should be run with --controller or with --spice-controller.
> >         (I don't like this option, think about slightly different paths
> >         in different distros)
> >       * remote-viewer is modified so that it behaves like when run with
> >         --spice-controller option if file speficied SPICE_XPI_SOCKET
> >         exists, ignoring other options
> 
> AFAICT, there's no need for this, since /usr/libexec/spice-xpi-client-remote-viewer
> already takes care of things
> 
> > I don't want to file concrete bugs until it is decided what is the best
> > way.
> 
> 
> Daniel

-- 

David Jaša, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24