[Spice-devel] xpi, spicec, remote-viewer & update-alternatives

[Daniel P. Berrange]

On Thu, Feb 23, 2012 at 03:38:28PM +0100, David Jaša wrote:
> Hi,
> 
> there is a problem with running the controller driven clients:
> 
>       * spice-xpi doesn't pass any option to spice-xpi-client symlink
>       * remote-viewer expects --spice-controller option

This shouldn't be any problem, as the spice-xpi-client alternative
is not pointing directly at /usr/bin/remote-viewer. Instead it
points to /usr/libexec/spice-xpi-client-remote-viewer.  This wrapper
script does *not* expect any option, and will automatically add in
--spice-controller before invoking remote-viewer.

>       * spicec expects --controller option
>       * spice-xpi doesn't know which client is target of
>         spice-xpi-client symlink
> 
> The result is that current xpi can not run any client. I can see two
> possibilites of getting this working again:
> 
>       * remote-viewer's --spice-controller option will change to
>         --controller, spice-xpi will always run spice-xpi-client with
>         --controller option
>       * some magic is added to XPI to recognize client to which
>         spice-xpi-client symlink points to and based on that, decide if
>         it should be run with --controller or with --spice-controller.
>         (I don't like this option, think about slightly different paths
>         in different distros)
>       * remote-viewer is modified so that it behaves like when run with
>         --spice-controller option if file speficied SPICE_XPI_SOCKET
>         exists, ignoring other options

AFAICT, there's no need for this, since /usr/libexec/spice-xpi-client-remote-viewer
already takes care of things

> I don't want to file concrete bugs until it is decided what is the best
> way.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|