[Spice-devel] [PATCH win-agent] build-sys: statically build agent

[Marc-André Lureau]

Hi

----- Mensaje original -----
> On Fri, Jun 08, 2012 at 01:14:02PM +0200, Marc-André Lureau wrote:
> > Fix build by default when using mingw (when more compiler are
> > supported we could do case by case)
> > 
> > Since we are statically building, strip resulting binary (we
> > also use lto, whole-program but that doesn't seem to change
> > much..)
> > ---
> >  Makefile.am  |    9 ++++++---
> >  configure.ac |    1 +
> >  2 files changed, 7 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 5f0c9dc..f954a8c 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -6,15 +6,18 @@ INCLUDES =				\
> >  	-I$(top_srcdir)/spice-protocol	\
> >  	$(NULL)
> >  
> > -AM_CPPFLAGS = -DUNICODE -D_UNICODE
> > +AM_CXXFLAGS = -flto -fwhole-program
> > +AM_CPPFLAGS = -DUNICODE -D_UNICODE -DOLDMSVCRT
> 
> Why the -DOLDMSVCRT?

See 60e850c6e48c5223d00591e1d85ad1a31dcd44c5

> > +AM_LDFLAGS = -static -s
> 
> Don't we want a way to keep debug info in the resulting binary?
> Looks good otherwise.

It's doable with make AM_LDFLAGS='' although this is not very friendly.

We could add a --enable-debug configure option, or
perhaps use LDFLAGS instead, since it is more user friendly, but that's
not really recommended as it may cause more harm than good.