[Spice-devel] [PATCH win-agent] build-sys: statically build agent

[Christophe Fergeau]

On Mon, Jun 11, 2012 at 06:20:35AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Mensaje original -----
> > On Fri, Jun 08, 2012 at 01:14:02PM +0200, Marc-André Lureau wrote:
> > > Fix build by default when using mingw (when more compiler are
> > > supported we could do case by case)
> > >
> > > Since we are statically building, strip resulting binary (we
> > > also use lto, whole-program but that doesn't seem to change
> > > much..)
> > > ---
> > >  Makefile.am  |    9 ++++++---
> > >  configure.ac |    1 +
> > >  2 files changed, 7 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Makefile.am b/Makefile.am
> > > index 5f0c9dc..f954a8c 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -6,15 +6,18 @@ INCLUDES =				\
> > >  	-I$(top_srcdir)/spice-protocol	\
> > >  	$(NULL)
> > >
> > > -AM_CPPFLAGS = -DUNICODE -D_UNICODE
> > > +AM_CXXFLAGS = -flto -fwhole-program
> > > +AM_CPPFLAGS = -DUNICODE -D_UNICODE -DOLDMSVCRT
> >
> > Why the -DOLDMSVCRT?
> 
> See 60e850c6e48c5223d00591e1d85ad1a31dcd44c5

So this was forgotten in this commit? or has it become necessary because we
want static linking with mingw libraries?
> 

> > > +AM_LDFLAGS = -static -s
> >
> > Don't we want a way to keep debug info in the resulting binary?
> > Looks good otherwise.
> 
> We could add a --enable-debug configure option

Yup, sounds like the best way to handle this.

ACK even though I much prefer commits that only do one thing, rather than
one main thing plus an assortment of various small changes. Much easier to
review when you don't have to guess what belong to the core change, and
what is a side change...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120611/387d50fb/attachment.pgp>