[Spice-devel] [PATCH] make celt to be optional

Michael Tokarev mjt at tls.msk.ru
Tue Jun 12 01:54:22 PDT 2012


On 12.06.2012 12:48, Alexander Larsson wrote:
> On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote:
> 
>> I plan to use this patch in the upcoming Debian
>> release, codename wheezy, to get rid of celt
>> codec library there, since we decided celt051 is
>> not going to be included, but it is obviously not
>> a good idea to drop spice entirely.
> 
> Isn't it better to drop spice completely rather than shipping a version
> thats essentially protocol incompatible? (Well, it will fall back to no
> audio or non-compressed audio, but that is untested and pretty bad for
> actual use of spice.) 

It isn't incompatible.  It might be incompatible with older releases
of spice where audio codec negotiation/fallback were not properly
implemented (read: was buggy), but it is okay now.  Did you read
the whole my email where I mention testing I performed?

> Then users that want to use spice can get a working version somewhere
> else instead of just thinking that spice sucks because of this change.

Thanks,

/mjt


More information about the Spice-devel mailing list