[Spice-devel] [PATCH] make celt to be optional

[Alexander Larsson]

On Tue, 2012-06-12 at 12:54 +0400, Michael Tokarev wrote:
> On 12.06.2012 12:48, Alexander Larsson wrote:
> > On Sat, 2012-06-02 at 15:46 +0400, Michael Tokarev wrote:
> > 
> >> I plan to use this patch in the upcoming Debian
> >> release, codename wheezy, to get rid of celt
> >> codec library there, since we decided celt051 is
> >> not going to be included, but it is obviously not
> >> a good idea to drop spice entirely.
> > 
> > Isn't it better to drop spice completely rather than shipping a version
> > thats essentially protocol incompatible? (Well, it will fall back to no
> > audio or non-compressed audio, but that is untested and pretty bad for
> > actual use of spice.) 
> 
> It isn't incompatible.  It might be incompatible with older releases
> of spice where audio codec negotiation/fallback were not properly
> implemented (read: was buggy), but it is okay now.  Did you read
> the whole my email where I mention testing I performed?

Its not incompatible, like I i said in my "(Well, .." part above. But
what it means is that it will send audio as PCM instead of compressing
it. This is much larger, and will cause anyone using the debian spice
client to connect to a spice server (even one that supports celt) to use
much more bandwidth due to this. Its not very obvious that the reason
for this is that Debian decided to package Spice that way, but rather
the likely conclusion that any user would draw is that Spice just works
like that. Thats not exactly a good impression for Spice.