[Spice-devel] [PATCH] make celt to be optional

[Christophe Fergeau]

On Tue, Jun 12, 2012 at 09:59:39AM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Mensaje original -----
> > On Tue, Jun 12, 2012 at 09:11:24AM -0400, Marc-André Lureau wrote:
> > > As long as the bitstream is not frozen, we can't use opus, or we
> > > will
> > > have the same problems as with celt today.
> >
> > As I understand it, while the bitstream is not officially frozen yet,
> > it's
> > very unlikely to change before the real freeze (unless big last
> > minute
> > issues are fine), so an Opus mode (marked as "no compat guarantees,
> > use at
> > your own risk, ...") will probably not cause significant
> > compatibilities issues.
> 
> That's just guesses. It's not about library API, but about bitstream.
> There is no guarantee.

A guess supported by the slides at http://www.opus-codec.org/presentations/
, by various mailing posts from opus developers, ...

> Sticking to celt051 is still a safer alternative.

Not suggesting dropping celt051 support upstream...

> Otherwise, how would you identify almost-frozen bitstream to frozen bitstream?
> You would have to identify by library version (erk!)
> and be compatible with the old and new bitstram (which might be complicated
> depending on library design), or be incompatible with the intermediate version,
> situation which we better avoid!

We would make no guarantee with interoperability between binaries using
different opus versions until the format is officially frozen. I agree
there's a bit of uncertainty in this move, but I think that at this point
it's a reasonable assumption that things will work, even with different
opus versions.

> 
> > > Sadly, I think debian folks aren't looking at what is really
> > > celt051.
> >
> > It's not really an old and unmaintained release of celt ?
> 
> If something would show up, the spice team would
> certainly update it. So I wouldn't say unmaintained.

Is anyone from the team monitoring celt security issues and whether they
apply to celt 0.5.1?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20120612/36c1fb3b/attachment.pgp>