[Spice-devel] [PATCH] make celt to be optional

[Marc-André Lureau]

Hi

----- Mensaje original -----
> A guess supported by the slides at
> http://www.opus-codec.org/presentations/
> , by various mailing posts from opus developers, ...
> 

Can you quote the relevant part of the slide?

According to
http://www.opus-codec.org/downloads/

The bit-stream was tentatively frozen several times, and broke from time to time (in 0.9.8 at least).

> > Sticking to celt051 is still a safer alternative.
> 
> Not suggesting dropping celt051 support upstream...

Why do you suggest that?
 
> > Otherwise, how would you identify almost-frozen bitstream to frozen
> > bitstream?
> > You would have to identify by library version (erk!)
> > and be compatible with the old and new bitstram (which might be
> > complicated
> > depending on library design), or be incompatible with the
> > intermediate version,
> > situation which we better avoid!
> 
> We would make no guarantee with interoperability between binaries
> using
> different opus versions until the format is officially frozen. I
> agree
> there's a bit of uncertainty in this move, but I think that at this
> point
> it's a reasonable assumption that things will work, even with
> different
> opus versions.

We don't want to introduce changes that will break in the future, even knowingly, as we want to maintain compatibility. That's the reason why the update celt codec never went upstream. But we can't force people from not forking and do what pleases them. Regarding current Spice upstream, we better stay off those experimental and unstable path.

> > > > Sadly, I think debian folks aren't looking at what is really
> > > > celt051.
> > >
> > > It's not really an old and unmaintained release of celt ?
> > 
> > If something would show up, the spice team would
> > certainly update it. So I wouldn't say unmaintained.
> 
> Is anyone from the team monitoring celt security issues and whether
> they
> apply to celt 0.5.1?

I would be really surprised if nobody is fixing spice celt security issues for RHEL.