[Spice-devel] [PATCH] make celt to be optional

[Alon Levy]

On Wed, Jun 13, 2012 at 09:25:59AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >> More official than the codec working group declaring it to be in its
> >> finally frozen form, or the codec specification being submitted to and
> >> approved by the IESG for publication?
> > 
> > You keep refering to standards, while I am talking about what we can
> > actually rely on, the implementation.
> 
> I'd be very surprised if the most recent opus release doesn't conform to
> the submitted specification.  Guess the 1.0 release just waits for the
> formal approval & publication
> 
> >>> This is not helping, we have implementations not really frozen.
> 
> ???
> 
> Can't see what your problem is ...
> 
> >>> Since no releases happened recently, I assume no security issues are known.
> >>
> >> That's an interesting assumption ...
> > 
> > Isn't it how security works? It's safe until it's proven it's no
> > longer, isn't it?
> 
> For a piece of software not being actively maintained any more by anyone
> I wouldn't bet on it.
> 
> > Spice depends on celt 0.5.1, people do care.
> 
> What kind of care, beyond packaging & using it?
> 
> >> It's your decision what you do with spice.  But saying "Opus isn't ready yet"
> >> is simply not true.  You may have other reasons not to use it, but that isn't
> >> one of them that stands up to genuine scrutiny.
> > 
> > Personally, I would be glad to have opus support once there is an
> > implementation the spice server can rely on.
> 
> IMHO we should undust Alons opus patches *now* and get stuff ready.
> Given the sample rate issue a bit more work that just switching the
> codec, so it will need some time anyway.

I replied to Ron privately but let me repeat my problems last time
around. They are certainly not unsurmountable, I just didn't have the
right motivation, that Ron provided right now (i.e. saying that we might
be carrying a breakable package):
 We have a fixed sample rate of 44100 in spiceaudio, as defined by spice
 server. I guess I could try to either resample (didn't want to go down
 that path last time since it seemed a waste of cpu for something I
 could just adjust upfront in the guest/client for playback/recording)
 or change it. I can start by seeing if changing the rate breaks
 anything using celt, if not I can change it for both celt and opus. If
 it does break I still have the options of either having a single codec
 enabled, or doing resampling and providing the older sampling rate (and
 then some time in the future when we drop celt we can drop the
 resampling).

Alon
> 
> cheers,
>   Gerd
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel