[Spice-devel] [PATCH] make celt to be optional

Gerd Hoffmann kraxel at redhat.com
Wed Jun 13 04:49:59 PDT 2012


  Hi,

>> IMHO we should undust Alons opus patches *now* and get stuff ready.
>> Given the sample rate issue a bit more work that just switching the
>> codec, so it will need some time anyway.
> 
> I replied to Ron privately but let me repeat my problems last time
> around. They are certainly not unsurmountable, I just didn't have the
> right motivation, that Ron provided right now (i.e. saying that we might
> be carrying a breakable package):
>  We have a fixed sample rate of 44100 in spiceaudio, as defined by spice
>  server. I guess I could try to either resample (didn't want to go down
>  that path last time since it seemed a waste of cpu for something I
>  could just adjust upfront in the guest/client for playback/recording)
>  or change it.

It's a waste indeed, and I think the best long-term option is to go for
48 kHz.  Real hardware does this, virtual qemu hardware does this, and
using it on the complete path from guest to spice client makes perfect
sense.

I suspect there is no way around resampling support though.  We'll need
it for compatibility reasons, so sound keeps working if only one side is
able to operate at 48 kHz.

cheers,
  Gerd



More information about the Spice-devel mailing list