[Spice-devel] [vdagent-win] mingw: Don't define OLDMSCVRT for mingw builds

[Christophe Fergeau]

On Mon, Nov 19, 2012 at 08:33:36AM -0500, Marc-André Lureau wrote:
> ----- Mensaje original -----
> > When it's defined, this causes some fallback code to be used. In
> > particular, this causes log messages to not get timestamps.
> > Issue reported by Han Pilmeyer.
> 
> You can also try to implement timing with old/default msvcrt, but I
> wouldn't bother going in that direction.

Depends on the amount of work, could be just a few lines of code.

> 
> Ie, do we require a newer MSVCRT and keep doing logging the wrong way, or
> do we use default MSVCRT and switch to a proper logging. I don't think
> the timestamp are really wanted here anyway (why is it needed in the
> first place?), and people who need it can compile the agent without
> OLDMSVCRT or with MSVC.

Depends how new is the newer MSVCRT. If it's present in winxp sp3 and
newer, we should be good. I assume MSVCRT is always dynamically linked?
mingw-vdagent uses -static when building, and built successfully with this
change. How does this work with MSVC++ builds by the way? Do they
statically link with the newer msvcrt version?

Regarding timestamps in logs, they are useful to know how recent a log is,
ie can the issue I just got be related to this weird log line, or has this
log been present in the file for days now?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20121119/53550cf3/attachment.pgp>