[Spice-devel] [PATCH vdagent-linux] vdagentd: send monitors config to currently active agent only

[Hans de Goede]

Hi,

On 11/22/2012 11:58 AM, Marc-André Lureau wrote:
> Hi
>
> ----- Mensaje original -----
>>> +    /* Send monitor config to currently active agent */
>>> +    udscs_write(active_session_conn, VDAGENTD_MONITORS_CONFIG, 0,
>>> 0,
>>> +                (uint8_t *)mon_config, size);
>>>
>>>        /* Acknowledge reception of monitors config to spice server /
>>>        client */
>>>        reply.type  = VD_AGENT_MONITORS_CONFIG;
>>>
>>
>> Good catch! This may very well explain much if the issues we've been
>> seeing. But this needs some
>> more work, we need to also send an (potentially updated)
>> monitor-config to the
>> new active-agent when the active session changes, ie, we've 2 agents
>> running for 2 sessions
>> not sharing the same X-server, ie using user switching, then when we
>> switch to the other user,
>> the agent should be notified so that the resolution of the other
>> X-server gets adjusted too.
>
> I was thinking to rely on X events for that, if they exist.

I don't think they do.

> Also, I think we shouldn't wait for that extra work to apply the above fix, since error is much more likely to happen currently than with the multiple session agents situation (and that might be a recoverable situation).

Agreed on that part, so ack for the fix.

Regards,

Hans