[Spice-devel] [PATCH vdagent-linux] vdagentd: send monitors config to currently active agent only

[David Jaša]

Hans de Goede píše v Čt 22. 11. 2012 v 12:16 +0100:
> Hi,
> 
> On 11/22/2012 11:58 AM, Marc-André Lureau wrote:
> > Hi
> >
> > ----- Mensaje original -----
> >>> +    /* Send monitor config to currently active agent */
> >>> +    udscs_write(active_session_conn, VDAGENTD_MONITORS_CONFIG, 0,
> >>> 0,
> >>> +                (uint8_t *)mon_config, size);
> >>>
> >>>        /* Acknowledge reception of monitors config to spice server /
> >>>        client */
> >>>        reply.type  = VD_AGENT_MONITORS_CONFIG;
> >>>
> >>
> >> Good catch! This may very well explain much if the issues we've been
> >> seeing. But this needs some
> >> more work, we need to also send an (potentially updated)
> >> monitor-config to the
> >> new active-agent when the active session changes, ie, we've 2 agents
> >> running for 2 sessions
> >> not sharing the same X-server, ie using user switching, then when we
> >> switch to the other user,
> >> the agent should be notified so that the resolution of the other
> >> X-server gets adjusted too.
> >
> > I was thinking to rely on X events for that, if they exist.
> 
> I don't think they do.

Do they exist at least for head count and status (monitor connected/disconnected)? If so, moving these from agent do driver (or device) could essentially allow to have more heads without agent being alive and well...

David

> 
> > Also, I think we shouldn't wait for that extra work to apply the above fix, since error is much more likely to happen currently than with the multiple session agents situation (and that might be a recoverable situation).
> 
> Agreed on that part, so ack for the fix.
> 
> Regards,
> 
> Hans
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

-- 

David Jaša, RHCE

SPICE QE based in Brno
GPG Key:     22C33E24 
Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24