[Spice-devel] [PATCH spice-protocol V2] vd_agent.h: drag-and-drop support

[Dunrong Huang]

Hi,

2012/11/23 Hans de Goede <hdegoede at redhat.com>:
> Hi Dunrong Huang,
>
> Thanks for your continued work on this!
>
> And sorry that we keep tweaking the protocol, but getting the
> protocol right is very important as we cannot change that later.
>
I know it and very agree with you, :-)

The following is my summary of discussions:

1) For file information, use a key-value text passed from client to
guest instead of using stuff that is hard to extend.
    I like this approach too, :-).

   So VDAgentFileXferStartMessage will become:
typedef struct SPICE_ATTR_PACKED VDAgentFileXferStartMessage {
   uint32_t id;
   uint64_t size;
   uint8_t data[0];
} VDAgentFileXferStartMessage;

2) s/VD_AGENT_FILE_XFER_RESULT_/VD_AGENT_FILE_XFER_STATUS_/
    s/VD_AGENT_FILE_XFER_RESULT_SUCCESS/VD_AGENT_FILE_XFER_STATUS_CAN_SEND_DATA/

3) Drop data compression, it can be done later(with extensible key-value text)

4) Which library will be used for parsing key-value text on agent end,
glib or something like http://ndevilla.free.fr/iniparser/?
     It need more discussion.

Hans and Marc-André,
Whether patch V3 is welcome or not, or something need to be discussed?

>
> On 11/23/2012 02:02 PM, Dunrong Huang wrote:
>>
>> Hi, Marc-André
>>
>> Thanks for reply
>>
>> 2012/11/23 Marc-André Lureau <mlureau at redhat.com>:
>>>
>>> Hi
>>>
>>> ----- Mensaje original -----
>>>>
>>>> At present, Vmware and Virtualbox has supported file drag&drop
>>>> feature,
>>>> I think it's a good feature for users, so we want qemu/spice to
>>>> supports it.
>>>
>>>
>>> Btw, have you done a small comparison of what VirtualBox can support and
>>> how it is implemented?
>>
>> I made a simple research how virtualbox implement dnd on client side,
>> since only client source is opensource.
>> It's more complex than what we do.
>> You can take a simple look at in this page:
>>
>> http://www.virtualbox.org/svn/vbox/trunk/include/VBox/HostServices/DragAndDropSvc.h
>
>
> Hmm, looks like they have a very generic drag and drop mechanism between the
> client
> and their agent. I wonder if they support actual arbitrary drag and drop
> between
> client and guest (I don't think so)? Anyways if we want that we can always
> add something
> like that later, for now we are focussing on drag and drop of files only.
>
> Regards,
>
> Hans



-- 
Best Regards,

Dunrong Huang