[Spice-devel] [PATCH spice-protocol V2] vd_agent.h: drag-and-drop support

[Hans de Goede]

Hi,

On 11/26/2012 05:30 AM, Dunrong Huang wrote:
> Hi,
>
> 2012/11/23 Hans de Goede <hdegoede at redhat.com>:
>> Hi Dunrong Huang,
>>
>> Thanks for your continued work on this!
>>
>> And sorry that we keep tweaking the protocol, but getting the
>> protocol right is very important as we cannot change that later.
>>
> I know it and very agree with you, :-)
>
> The following is my summary of discussions:
>
> 1) For file information, use a key-value text passed from client to
> guest instead of using stuff that is hard to extend.
>      I like this approach too, :-).
>
>     So VDAgentFileXferStartMessage will become:
> typedef struct SPICE_ATTR_PACKED VDAgentFileXferStartMessage {
>     uint32_t id;
>     uint64_t size;
>     uint8_t data[0];
> } VDAgentFileXferStartMessage;
>

I assume size here is the file size in bytes ? One could argue this
belongs in the key-value text too. But this one is special because it
needs to exactly match the combined size of the data messages send later,
so I think having it separately makes sense, so ACK (acknowledge /
I agree) for that.

> 2) s/VD_AGENT_FILE_XFER_RESULT_/VD_AGENT_FILE_XFER_STATUS_/
>      s/VD_AGENT_FILE_XFER_RESULT_SUCCESS/VD_AGENT_FILE_XFER_STATUS_CAN_SEND_DATA/
>

ACK.

> 3) Drop data compression, it can be done later(with extensible key-value text)
>

ACK.

> 4) Which library will be used for parsing key-value text on agent end,
> glib or something like http://ndevilla.free.fr/iniparser/?
>       It need more discussion.

I think we're are in agreement to just use glibs keyfile code for this,
the client and the linux agent already use glib so it makes sense
to start using glib in the windows agent too, rather then adding some
other new dependency to all 3.

> Hans and Marc-André,
> Whether patch V3 is welcome or not, or something need to be discussed?

I believe a v3 is welcome, but lets wait for Marc-André's input.

Regards,

Hans