[Spice-devel] [spice-gtk] Fix GNetworkAddress leak when opening spice session

Marc-André Lureau mlureau at redhat.com
Sat Apr 13 07:21:40 PDT 2013


Is the connectable referenced during the async op?

----- Mensaje original -----
> ACK.
> 
> On 04/13/2013 01:34 PM, Christophe Fergeau wrote:
> > ---
> >   gtk/spice-session.c | 9 +++++++--
> >   1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> > index f472027..44d42f2 100644
> > --- a/gtk/spice-session.c
> > +++ b/gtk/spice-session.c
> > @@ -1744,8 +1744,13 @@ static gboolean open_host_idle_cb(gpointer data)
> >                                           proxy_lookup_ready, open_host);
> >       else
> >   #endif
> > -        open_host_connectable_connect(open_host,
> > -                                      g_network_address_new(s->host,
> > open_host->port));
> > +    {
> > +        GSocketConnectable *address;
> > +
> > +        address = g_network_address_new(s->host, open_host->port);
> > +        open_host_connectable_connect(open_host, address);
> > +        g_object_unref(address);
> > +    }
> >
> >       SPICE_DEBUG("open host %s:%d", s->host, open_host->port);
> >       if (open_host->proxy != NULL) {
> >
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list