[Spice-devel] [spice-gtk] Fix GNetworkAddress leak when opening spice session

Christophe Fergeau cfergeau at redhat.com
Sat Apr 13 10:04:13 PDT 2013


On Sat, Apr 13, 2013 at 10:21:40AM -0400, Marc-André Lureau wrote:
> Is the connectable referenced during the async op?

It has to, or this would be racy. I've checked the code now, and
it indeed does:

void
g_socket_client_connect_async (GSocketClient       *client,
                               GSocketConnectable  *connectable,
                               GCancellable        *cancellable,
                               GAsyncReadyCallback  callback,
                               gpointer             user_data)
{
  GSocketClientAsyncConnectData *data;

  g_return_if_fail (G_IS_SOCKET_CLIENT (client));

  data = g_slice_new0 (GSocketClientAsyncConnectData);
  data->client = client;
  data->connectable = g_object_ref (connectable);


Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130413/0a7e9300/attachment.pgp>


More information about the Spice-devel mailing list