[Spice-devel] [PATCH spice-gtk 4/5] usb-device-manager: Fix redirect_on_connect_rules mem-leak

[Hans de Goede]

Hi,

On 04/23/2013 08:14 PM, Christophe Fergeau wrote:
> On Tue, Apr 23, 2013 at 02:19:51PM +0200, Hans de Goede wrote:
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>   gtk/usb-device-manager.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
>> index 75406a4..7575417 100644
>> --- a/gtk/usb-device-manager.c
>> +++ b/gtk/usb-device-manager.c
>> @@ -314,6 +314,7 @@ static void spice_usb_device_manager_finalize(GObject *gobject)
>>       if (priv->event_thread)
>>           g_thread_join(priv->event_thread);
>>       free(priv->auto_conn_filter_rules);
>> +    free(priv->redirect_on_connect_rules);
>
> This should be a g_free

No, just like the free right above it, it should be a regular free, the rules
are allocated by usbredirfilter_string_to_rules(), quoting from
usbredirfilter.h: "the returned rules array should be freed with free()"

Regards,

Hans