[Spice-devel] [PATCH spice-gtk 4/5] usb-device-manager: Fix redirect_on_connect_rules mem-leak

Christophe Fergeau cfergeau at redhat.com
Wed Apr 24 01:04:05 PDT 2013


On Wed, Apr 24, 2013 at 09:18:11AM +0200, Hans de Goede wrote:
> On 04/23/2013 08:14 PM, Christophe Fergeau wrote:
> >
> >This should be a g_free
> 
> No, just like the free right above it, it should be a regular free, the rules
> are allocated by usbredirfilter_string_to_rules(), quoting from
> usbredirfilter.h: "the returned rules array should be freed with free()"

Yes, my bad, I was looking at priv->redirect_on_connect during the review,
not priv->redirect_on_connect_rules. The former seems to be leaked as well,
and this one needs g_free().

ACK

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130424/d8edeebe/attachment.pgp>


More information about the Spice-devel mailing list