[Spice-devel] [spice-gtk] Only use GOBJECT_INTROSPECTION_CHECK when available

[Uri Lublin]

On 08/13/2013 06:16 PM, Christophe Fergeau wrote:

Hi Christophe,

Thanks for this patch.

> diff --git a/configure.ac b/configure.ac
> index 11f11fc..1235f4a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -537,11 +537,13 @@ AM_CONDITIONAL(WITH_WINFIBER, [test "x$WITH_WINFIBER" = "x1"])
>   AC_DEFINE_UNQUOTED(WITH_GTHREAD,[$WITH_GTHREAD], [Whether to use gthread coroutine impl])
>   AM_CONDITIONAL(WITH_GTHREAD, [test "x$WITH_GTHREAD" = "x1"])
>   
> -AM_CONDITIONAL([HAVE_INTROSPECTION], [test "0" != "1"])
> -PKG_CHECK_EXISTS([GOBJECT_INTROSPECTION],
> -        [gobject-introspection-1.0 >= 0.9.4],
> -        [has_symbol_prefix=yes], [:])
> -GOBJECT_INTROSPECTION_CHECK([0.6.7])
> +AM_CONDITIONAL([HAVE_INTROSPECTION], [test "0" = "1"])



With this line HAVE_INTROSPECTION is set to false.
Does HAVE_INTROSPECTION changes within GOBJECT_INTROSPECTION_CHECK below ?
If not maybe it's better to set HAVE_INTROSPECTION within the m4_ifdef
(and add an "else" clause) or set it based on GOBJECT_INTROSPECTION.

Thanks,
     Uri.

> +m4_ifdef([GOBJECT_INTROSPECTION_CHECK],[
> +    PKG_CHECK_EXISTS([GOBJECT_INTROSPECTION],
> +            [gobject-introspection-1.0 >= 0.9.4],
> +            [has_symbol_prefix=yes], [:])
> +    GOBJECT_INTROSPECTION_CHECK([0.6.7])
> +])
>   AM_CONDITIONAL([G_IR_SCANNER_SYMBOL_PREFIX], [test "x$has_symbol_prefix" = "xyes"])
>   
>   AC_ARG_ENABLE([controller],