[Spice-devel] [spice-gtk] Only use GOBJECT_INTROSPECTION_CHECK when available

[Christophe Fergeau]

Hi Uri,


Sorry, I've pushed this patch before seeing your email :(

On Wed, Aug 14, 2013 at 11:08:33AM +0300, Uri Lublin wrote:
> On 08/13/2013 06:16 PM, Christophe Fergeau wrote:
> >diff --git a/configure.ac b/configure.ac
> >index 11f11fc..1235f4a 100644
> >--- a/configure.ac
> >+++ b/configure.ac
> >@@ -537,11 +537,13 @@ AM_CONDITIONAL(WITH_WINFIBER, [test "x$WITH_WINFIBER" = "x1"])
> >  AC_DEFINE_UNQUOTED(WITH_GTHREAD,[$WITH_GTHREAD], [Whether to use gthread coroutine impl])
> >  AM_CONDITIONAL(WITH_GTHREAD, [test "x$WITH_GTHREAD" = "x1"])
> >-AM_CONDITIONAL([HAVE_INTROSPECTION], [test "0" != "1"])
> >-PKG_CHECK_EXISTS([GOBJECT_INTROSPECTION],
> >-        [gobject-introspection-1.0 >= 0.9.4],
> >-        [has_symbol_prefix=yes], [:])
> >-GOBJECT_INTROSPECTION_CHECK([0.6.7])
> >+AM_CONDITIONAL([HAVE_INTROSPECTION], [test "0" = "1"])
> 
> 
> 
> With this line HAVE_INTROSPECTION is set to false.
> Does HAVE_INTROSPECTION changes within GOBJECT_INTROSPECTION_CHECK below ?

I hadn't checked what GOBJECT_INTROSPECTION_CHECK does with that variable
before your email, but my reasoning was that it had to change it as:
- --enable-introspection/--disable-introspection would not be working if
  GOBJECT_INTROSPECTION_CHECK was not adjusting HAVE_INTROSPECTION
  depending on that flag
- I checked that on a system with gobject-introspection installed,
  ./autogen.sh builds the introspection files as expected

Looking at the macro code, it does indeed set HAVE_INTROSPECTION:
https://git.gnome.org/browse/gobject-introspection/tree/m4/introspection.m4#n76

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130814/3aaa4a51/attachment.pgp>