[Spice-devel] VM pools and libgovirt

[i iordanov]

Hi Christophe,

I have another patch for you to consider. This one removes some duplicated
code by creating and using a utility function to ovirt-utils.c. I also
switched out the two G_MAXUINT's in OvirtVmPool for G_MAXUINT32's.

We can make use of it any time an integer attribute needs to be parsed.
Maybe it should be in the OvirtResource class, but I'll leave that for you
to decide. Also, feel free to change naming or anything else you don't like.

Thanks!
iordan


On Thu, Dec 5, 2013 at 4:05 AM, Christophe Fergeau <cfergeau at redhat.com>wrote:

> On Wed, Dec 04, 2013 at 11:12:09PM -0500, i iordanov wrote:
> > On Wed, Dec 4, 2013 at 10:30 AM, Christophe Fergeau <cfergeau at redhat.com
> >wrote:
> > > It would be nice if you could check I did not break anything for you (I
> > > haven't tested ovirt_vm_pool_activate_vm() at all). Then I can push
> all of
> > > it to git master ;)
> > >
> >
> > I tested and it allocates VMs just as well as the before your changes. It
> > also reports the parsed attributes correctly for me.
>
> Cool, thanks for the testing, I can push it upstream then!
>
> Christophe
>



-- 
The conscious mind has only one thread of execution.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131206/a8d38a60/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reduced-code-duplication-in-OvirtVmPool-by-adding-a-.patch
Type: text/x-patch
Size: 7174 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131206/a8d38a60/attachment.bin>