[Spice-devel] VM pools and libgovirt

[i iordanov]

Hi Christophe,

On Mon, Dec 9, 2013 at 11:35 AM, Christophe Fergeau <cfergeau at redhat.com>wrote:

> Ah cool, thanks. This mostly looks good, though I'd probably add a check
> that the property has the right type using g_object_class_find_property.
>

That's a good idea.


>
> > I also switched out the two G_MAXUINT's in OvirtVmPool for G_MAXUINT32's.
>
> Hmm, I'm not sure about that one, what is the reasoning for it? I'd move
> this to a different commit.
>

Fair point about the different commit. I was aligning them to your choice
of making ovirt_utils_guint_from_string() return false if value64 exceeds
G_MAXUINT32.

This is a quick change, so I'll get you a new patch shortly.

Thanks!
iordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131209/5a811e4e/attachment.html>