[Spice-devel] [patch] Add missing format string in SpiceController::~SpiceController()

[Petter Reinholdtsen]

Hi.

The Debian package of spice-xpi failed to build on powerpc and sparc in
Debian, failing with this error message:

  make[6]: Entering directory `/«PKGBUILDDIR»/SpiceXPI/src/plugin'
    CXX    libnsISpicec_la-controller.lo
  controller.cpp: In destructor 'SpiceController::~SpiceController()':
  controller.cpp:73:5: error: format not a string literal and no format
    arguments [-Werror=format-security]
  cc1plus: some warnings being treated as errors

The error is in a call to g_debug, and this patch fixes the problem:

--- spice-xpi-2.8.orig/SpiceXPI/src/plugin/controller.cpp
+++ spice-xpi-2.8/SpiceXPI/src/plugin/controller.cpp
@@ -70,7 +70,7 @@ SpiceController::SpiceController(const s
 
 SpiceController::~SpiceController()
 {
-    g_debug(G_STRFUNC);
+    g_debug("%s", G_STRFUNC);
     Disconnect();
 }
 

Please include the patch in a future version of spice-xpi.

PS: I am not subscribed, so keep me on CC if you have questions.

-- 
Happy hacking
Petter Reinholdtsen
The Debian maintainer of spice-xpi