[Spice-devel] [PATCH spice-gtk 1/2] channel-display: Make monitors array contain monitors in id order

[Hans de Goede]

Hi,

On 01/11/2013 08:55 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Jan 10, 2013 at 11:52 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>> Both the spice-widget code, as well as remote-viewer expect that
>> monitors[i]->id == i, but if ie only the qxl-0 and qxl-2 outputs are
>> enabled this is not true.
>
> Can you detail where and how there is such expectation in
> remote-viewer or spice-gtk code?
>


spice-widget.c: update_monitor_area()

     c = &g_array_index(monitors, SpiceDisplayMonitorConfig, d->monitor_id);


virt-viewer-session-spice.c: virt_viewer_session_spice_display_monitors():

         display = g_ptr_array_index(displays, monitor->id);

Regards,

Hans