[Spice-devel] [PATCH spice-gtk 1/2] channel-display: Make monitors array contain monitors in id order

Marc-André Lureau marcandre.lureau at gmail.com
Fri Jan 11 14:45:45 PST 2013


Hi

On Fri, Jan 11, 2013 at 10:51 PM, Hans de Goede <hdegoede at redhat.com> wrote:

>
> spice-widget.c: update_monitor_area()
>
>     c = &g_array_index(monitors, SpiceDisplayMonitorConfig, d->monitor_id);
>

>
> virt-viewer-session-spice.c: virt_viewer_session_spice_display_monitors():
>
>         display = g_ptr_array_index(displays, monitor->id);

Ah, I think this is correct as the current model doesn't allow qxl-0
and qxl-2 outputs enabled, while qxl-1 is disabled.

I don't remember why we chose this approach, I remember we discussed
it with Alon. So if we change the model by using "sparse" monitors
config like you propose, then the patch makes sense.

--
Marc-André Lureau


More information about the Spice-devel mailing list