[Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

Hans de Goede hdegoede at redhat.com
Fri Jan 11 14:02:13 PST 2013


Hi,

On 01/11/2013 10:34 PM, Jeremy White wrote:
> This makes the default display not stretch for 4096x768.

Hmm this seems to expose a problem with your previous patch then,
as this second patch is not acceptable. Currently the user can
on the fly add new monitors to guests running the agent by
simply inside the remote-viewer window going to view->displays
and select an extra one, this would break that.

So nack series.

Regards,

Hans


>
> Signed-off-by: Jeremy White <jwhite at codeweavers.com>
> ---
>   src/qxl_driver.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> index c7a07cb..3dae401 100644
> --- a/src/qxl_driver.c
> +++ b/src/qxl_driver.c
> @@ -78,7 +78,7 @@ const OptionInfoRec DefaultOptions[] =
>       { OPTION_ENABLE_SURFACES,
>         "EnableSurfaces",           OPTV_BOOLEAN, { 0 }, TRUE },
>       { OPTION_NUM_HEADS,
> -      "NumHeads",                 OPTV_INTEGER, { 4 }, FALSE },
> +      "NumHeads",                 OPTV_INTEGER, { 1 }, FALSE },
>   #ifdef XSPICE
>       { OPTION_SPICE_PORT,
>         "SpicePort",                OPTV_INTEGER,   {5900}, FALSE },
>


More information about the Spice-devel mailing list