[Spice-devel] [PATCH spice-gtk 1/2] channel-display: Make monitors array contain monitors in id order

[Hans de Goede]

Hi,

On 01/11/2013 11:45 PM, Marc-André Lureau wrote:
> Hi
>
> On Fri, Jan 11, 2013 at 10:51 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>
>>
>> spice-widget.c: update_monitor_area()
>>
>>      c = &g_array_index(monitors, SpiceDisplayMonitorConfig, d->monitor_id);
>>
>
>>
>> virt-viewer-session-spice.c: virt_viewer_session_spice_display_monitors():
>>
>>          display = g_ptr_array_index(displays, monitor->id);
>
> Ah, I think this is correct as the current model doesn't allow qxl-0
> and qxl-2 outputs enabled, while qxl-1 is disabled.

That is not entirely true, currently one cannot do that through an
agent message, but one can "easily" do it using the xrandr cmdline
utility. So the code is already broken, the xorg driver and qemu/server
code can send a QXLMonitorsConfig with non continues id range in
there already, it just requires manual configuration inside the guest.

Regards,

Hans