[Spice-devel] [PATCH spice-gtk 1/2] channel-display: Make monitors array contain monitors in id order

[Hans de Goede]

Hi,

On 01/13/2013 03:07 PM, Marc-André Lureau wrote:
> Hi
>
> ----- Mensaje original -----
>
>> 1) No agent running -> the "display-2 window with waiting for
>> connection"
>>      stays that way forever
>> 2) Agent running:
>>      1) There is a wrong intermediate state
>>      2) The user asked for output3 but gets output2 instead
>
> That looks like the right thing to do since we didn't support sparse monitors (the messages were meant to reflect real physical connected monitors). Now if we want to support it, that's something different. I will try those patches next week. I hope I am not missing something obvious though..

<sigh>, we do already support sparse monitors in:
1) The spice protocol (in the monitors message in the display channel)
2) spice-server, it even contains special code to "compress" sparse QXLMonitorConfigs
    into a shorter monitors message
3) xorg-x11-drv-qxl

The only thing not supporting it is:
a) spice-gtk
b) The agent-protocol, and through that the agent itself and
    the agent parts of spice-gtk

This patch is to fix a, which is pretty much orthogonal to b,
I agree it is currently not a big deal because of the lack of
agent support for sparse monitor configs, but please stop
pretending a) is not a bug by and in itself.

Regards,

Hans