[Spice-devel] [PATCH spice-gtk 1/2] channel-display: Make monitors array contain monitors in id order

Hans de Goede hdegoede at redhat.com
Wed Jan 16 03:05:45 PST 2013


Hi,

On 01/11/2013 10:51 PM, Hans de Goede wrote:
> Hi,
>
> On 01/11/2013 08:55 PM, Marc-André Lureau wrote:
>> Hi
>>
>> On Thu, Jan 10, 2013 at 11:52 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>>> Both the spice-widget code, as well as remote-viewer expect that
>>> monitors[i]->id == i, but if ie only the qxl-0 and qxl-2 outputs are
>>> enabled this is not true.
>>
>> Can you detail where and how there is such expectation in
>> remote-viewer or spice-gtk code?
>>

It seems the discussion on this has gotten nowhere.

As you already said yourself, whether or not adding "empty"
monitors to the monitors property was needed before or not, is not
really relevant, since it will be needed anyways after my sparse
vdagent monitor config patches.

So I can please get your ack on this series ?

Thanks,

Hans



More information about the Spice-devel mailing list