[Spice-devel] [xf86-video-qxl warnings 5/6] Actually request the forcibly inline functions to be inline.

Christophe Fergeau cfergeau at redhat.com
Fri Mar 22 06:57:12 PDT 2013


On Fri, Mar 22, 2013 at 07:43:38AM -0500, Jeremy White wrote:
> >>>The '__attribute__((always_inline))' does not strictly imply 'inline'.
> >>>     Newer versions of gcc detect this misuse and issue the warning.
> >>>     Including the missing 'inline' resolves the build warning.
> >>
> >>Looked reasonable to me, hence the patch.
> >
> >I'd expect gcc to inline the function anyway, even without 'inline FORCE_INLINE'
> 
> Yeah, I think it does. But then it warns you about it.  I just quiet the warning.

What I meant is no inline, no FORCE_INLINE, nothing, just let gcc optimizer
decide about the inlining.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130322/acdca98d/attachment.pgp>


More information about the Spice-devel mailing list