[Spice-devel] [xf86-video-qxl warnings 5/6] Actually request the forcibly inline functions to be inline.

[Jeremy White]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/22/2013 08:57 AM, Christophe Fergeau wrote:
> On Fri, Mar 22, 2013 at 07:43:38AM -0500, Jeremy White wrote:
>>>>> The '__attribute__((always_inline))' does not strictly
>>>>> imply 'inline'. Newer versions of gcc detect this misuse
>>>>> and issue the warning. Including the missing 'inline'
>>>>> resolves the build warning.
>>>> 
>>>> Looked reasonable to me, hence the patch.
>>> 
>>> I'd expect gcc to inline the function anyway, even without
>>> 'inline FORCE_INLINE'
>> 
>> Yeah, I think it does. But then it warns you about it.  I just
>> quiet the warning.
> 
> What I meant is no inline, no FORCE_INLINE, nothing, just let gcc
> optimizer decide about the inlining.

Ah, sorry to misunderstand.  That's a reasonable question, but I think
outside the scope of what I was trying to accomplish.

Cheers,

Jeremy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlFMb5UACgkQq6U76EE4uyfcLwCZAaR7PyeL27LU0APF4s9MheMd
I4kAnj9m4Sn5GobL4+R6DfgqlvGDkCsu
=JEKJ
-----END PGP SIGNATURE-----