[Spice-devel] [PATCH spice-gtk] widget: remove grab key filter

Marc-André Lureau marcandre.lureau at gmail.com
Thu May 16 08:18:10 PDT 2013


The widget currently filters out last key press from grab key sequence
if it's not a modifier key. But this will prevent nested usage of ungrab
combinations such as shift+f12.

https://bugzilla.redhat.com/show_bug.cgi?id=889962

This will also make the following obsolete:
https://bugzilla.redhat.com/show_bug.cgi?id=846005
---
 gtk/spice-widget.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index 4f74380..4c67e26 100644
--- a/gtk/spice-widget.c
+++ b/gtk/spice-widget.c
@@ -1321,11 +1321,6 @@ static gboolean key_event(GtkWidget *widget, GdkEventKey *key)
             else
                 try_mouse_grab(display);
         }
-
-        // that's the last key pressed from the grab sequence
-        // let send it to the remote if it's a modifier key
-        if (!key->is_modifier)
-            return true;
     }
 
     if (!d->inputs)
-- 
1.8.3.rc1.49.g8d97506



More information about the Spice-devel mailing list