[Spice-devel] [PATCH spice-gtk] widget: remove grab key filter

[Christophe Fergeau]

On Thu, May 16, 2013 at 05:18:10PM +0200, Marc-André Lureau wrote:
> The widget currently filters out last key press from grab key sequence
> if it's not a modifier key. But this will prevent nested usage of ungrab
> combinations such as shift+f12.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=889962
> 
> This will also make the following obsolete:
> https://bugzilla.redhat.com/show_bug.cgi?id=846005

This code was added by

commit a18782415967fbc036608ccbba6005819ad7f58c
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date:   Thu May 17 23:41:37 2012 +0200

    If grab sequence is matched, still send modifier keys

    If the last key pressed from the grab sequence is a modifier
    key, let send it to the guest too.

    This solves the issue of default grab-sequence being ctrl+alt
    and preventing ctrl+alt+del from working.

Won't this cause a regression?

Christophe


> ---
>  gtk/spice-widget.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
> index 4f74380..4c67e26 100644
> --- a/gtk/spice-widget.c
> +++ b/gtk/spice-widget.c
> @@ -1321,11 +1321,6 @@ static gboolean key_event(GtkWidget *widget, GdkEventKey *key)
>              else
>                  try_mouse_grab(display);
>          }
> -
> -        // that's the last key pressed from the grab sequence
> -        // let send it to the remote if it's a modifier key
> -        if (!key->is_modifier)
> -            return true;
>      }
>  
>      if (!d->inputs)
> -- 
> 1.8.3.rc1.49.g8d97506
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20130516/02d857ef/attachment.pgp>