[Spice-devel] [spice-gtk] Fix g_return_val_if_fail() in spice_session_get_use_ca_file()

Christophe Fergeau cfergeau at redhat.com
Thu Nov 7 06:03:35 PST 2013


On Thu, Nov 07, 2013 at 03:01:03PM +0100, Christophe Fergeau wrote:
> spice_session_get_use_ca_file() returns a gboolean, but we were trying
> to return NULL from g_return_val_if_fail()
> ---
>  gtk/spice-session.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index c989f0a..60526fe 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -2120,7 +2120,7 @@ gboolean spice_session_get_use_system_ca_file(SpiceSession *session)
>  {
>      SpiceSessionPrivate *s = SPICE_SESSION_GET_PRIVATE(session);
>  
> -    g_return_val_if_fail(s != NULL, NULL);
> +    g_return_val_if_fail(s != NULL, FALSE);
>      return s->use_system_ca_file;

Never mind, this code is added in my (uncommitted) "Use system-wide trust
certificate store" series, I'll squash where appropriate.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131107/1a73edfa/attachment.pgp>


More information about the Spice-devel mailing list