[Spice-devel] [spice-gtk] Fix g_return_val_if_fail() in spice_session_get_use_ca_file()

Marc-André Lureau mlureau at redhat.com
Thu Nov 7 06:03:48 PST 2013


This is not upstream afaik (probably by lack of interest)

----- Original Message -----
> spice_session_get_use_ca_file() returns a gboolean, but we were trying
> to return NULL from g_return_val_if_fail()
> ---
>  gtk/spice-session.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index c989f0a..60526fe 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -2120,7 +2120,7 @@ gboolean
> spice_session_get_use_system_ca_file(SpiceSession *session)
>  {
>      SpiceSessionPrivate *s = SPICE_SESSION_GET_PRIVATE(session);
>  
> -    g_return_val_if_fail(s != NULL, NULL);
> +    g_return_val_if_fail(s != NULL, FALSE);
>      return s->use_system_ca_file;
>  
>  }
> --
> 1.8.4.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list