[Spice-devel] [spice-gtk 1/3] build-sys: Fix invalid 'test' syntax in configure.ac

Christophe Fergeau cfergeau at redhat.com
Fri Nov 15 09:20:15 PST 2013


test ... -o test ... is not a valid shell construct, change it to
test ... || test ... as this is more portable than test ... -o ...

This was causing a warning when running configure.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 2a6a955..231ee83 100644
--- a/configure.ac
+++ b/configure.ac
@@ -574,7 +574,7 @@ AC_ARG_WITH([python],
    yes|no) with_python="$withval";;
    *) AC_MSG_ERROR([bad value $withval for python option]) ;;
    esac],
-  [AS_IF([test "$with_gtk" = "3.0" -o test "x$os_win32=xyes"],
+  [AS_IF([test "$with_gtk" = "3.0" || test "x$os_win32" = "xyes"],
          [with_python=no])]
 )
 
-- 
1.8.4.2



More information about the Spice-devel mailing list