[Spice-devel] [spice-gtk 1/3] build-sys: Fix invalid 'test' syntax in configure.ac

Marc-André Lureau marcandre.lureau at gmail.com
Fri Nov 15 09:28:52 PST 2013


On Fri, Nov 15, 2013 at 6:20 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> test ... -o test ... is not a valid shell construct, change it to
> test ... || test ... as this is more portable than test ... -o ...
>
> This was causing a warning when running configure.

ack

> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 2a6a955..231ee83 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -574,7 +574,7 @@ AC_ARG_WITH([python],
>     yes|no) with_python="$withval";;
>     *) AC_MSG_ERROR([bad value $withval for python option]) ;;
>     esac],
> -  [AS_IF([test "$with_gtk" = "3.0" -o test "x$os_win32=xyes"],
> +  [AS_IF([test "$with_gtk" = "3.0" || test "x$os_win32" = "xyes"],
>           [with_python=no])]
>  )
>
> --
> 1.8.4.2
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau


More information about the Spice-devel mailing list