[Spice-devel] [PATCH spice-gtk 1/2] display: fix palette regression

[Christophe Fergeau]

On Thu, Oct 03, 2013 at 09:43:31AM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > On Thu, Oct 03, 2013 at 08:51:15AM -0400, Marc-André Lureau wrote:
> > > 
> > > 
> > > ----- Original Message -----
> > > > On Thu, Oct 03, 2013 at 01:53:55PM +0200, Marc-André Lureau wrote:
> > > > > palette_get() used to return a ref, and palette_release() used to
> > > > > release that ref.
> > > > > 
> > > > > Since ed877341, the palette is no longer refcount'ed, since its usage
> > > > > is
> > > > > exclusively local in common/canvas code.
> > > > > 
> > > > > palette_release() shouldn't remove the palette from the cache.
> > > > 
> > > > Doesn't this mean we will keep some palettes in the cache forever? If
> > > > yes,
> > > > some guarantee that the memory used by these palettes is bounded?
> > > 
> > > palette_get() / palette_release() always come in pair
> > 
> > Ah right, looks like we can even go with removal then:
> 
> Sure, but you'll have to fix server code too then.

Ah right, this is shared. It seems the server is not using it, but the old
client is :-/

ACK

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20131003/3d325206/attachment.pgp>