[Spice-devel] hardcoded NUM_DRAWABLES too small

Dietmar Maurer dietmar at proxmox.com
Wed Oct 9 14:31:25 CEST 2013


> > I just detected that my simple spiceterm generates more than
> >
> > 1000 drawables, so alloc_drawable() always fail.
> >
> >
> >
> > The effect is that I always draw twice (on server and at client)!
> 
> This is an area I am newbie ;)
> 
> Isn't the server always drawing anyway at some point?

No. There is no need to draw anything at the server side (for spiceterm).
 
> Isnt't the 1000 drawables limit just slowing down the caller (guest/vm side), to
> leave time for clients to process all drawables in the pipes.

no, it leads to additional draw commands on the server side. So this is a waste
of computing power.

> What alternative do you propose?

NUM_DRAWABLES=3000

but I guess that can have a negative performance impact elsewhere?

> > I guess one would see the same effect when running a xterm inside a
> > VM, because
> >
> > a terminal has a size of 80x25 characters, which gives 2000 different
> > regions.
> >
> >
> >
> > What is the suggested way to avoid such things?
> 
> I'll let someone else reply suggestion, as I don't know myself.
> 
> > Also, I don’t think I need the rendered content on the server side for
> > spiceterm (why?).
> 
> > So is it possible to disable server side rendering at all?
> 
> If you don't have client connected or for reconnection, you still want complete
> rendering ready, no?

No, I do not really need that. spiceterm only allows a single connection.



More information about the Spice-devel mailing list