[Spice-devel] vdagent protocol question

[Marc-André Lureau]

Hi

----- Original Message -----
> 
> 
> The clipboard message currently include an optional 4bytes enty for
> ‘selection’:
> 
> 
> 
> typedef struct SPICE_ATTR_PACKED VDAgentClipboardGrab {
> 
> #if 0 /* VD_AGENT_CAP_CLIPBOARD_SELECTION */
> 
> uint8_t selection;
> 
> uint8_t __reserved[sizeof(uint32_t) - 1 * sizeof(uint8_t)];
> 
> #endif
> 
> uint32_t types[0];
> 
> } VDAgentClipboardGrab;
> 
> 
> 
> This makes it really hard to write nice code.

I don't think I would have done it if it was "really" hard. But I understand in your code it might be difficult for some reason.

> 
> 
> I wonder why it does not simply use the ‘opaque’ field of VDAgentMessage
> instead?
> 

I have No idea what this opaque is for, but I prefer the information to be explicit.

What if you consider it as a different message with a different structure somehow?