[Spice-devel] [PATCH] mono cursor: increase contrast, better looking putty cursor (rhbz 998529)

[Hans de Goede]

Seems to make sense to me, ACK.

On 09/23/2013 03:10 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy <alevy at redhat.com>
> ---
> The previous fix is almost impossible to notice on putty, I'm assuming the
> original values for the on/off pixels were taken from a different use case, but
> so far since we do have a bug for putty and no bug for anything else I propose
> we fix the putty case first.
>
>   gtk/channel-cursor.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c
> index bbfb3c9..d1d2c34 100644
> --- a/gtk/channel-cursor.c
> +++ b/gtk/channel-cursor.c
> @@ -269,15 +269,15 @@ static void mono_cursor(display_cursor *cursor, const guint8 *data)
>                        * the same contrast.
>                        */
>                       if ((x ^ y) & 1) {
> -                        dest[0] = 0x30;
> -                        dest[1] = 0x30;
> -                        dest[2] = 0x30;
> -                        dest[3] = 0xc0;
> +                        dest[0] = 0xff;
> +                        dest[1] = 0xff;
> +                        dest[2] = 0xff;
> +                        dest[3] = 0xff;
>                       } else {
> -                        dest[0] = 0x50;
> -                        dest[1] = 0x50;
> -                        dest[2] = 0x50;
> -                        dest[3] = 0x30;
> +                        dest[0] = 0x00;
> +                        dest[1] = 0x00;
> +                        dest[2] = 0x00;
> +                        dest[3] = 0x00;
>                       }
>                   } else {
>                       /* unchanged -> transparent */
>