[Spice-devel] [PATCH 4/4] gl: use glCopyPixels()

[Marc-André Lureau]

----- Original Message -----
> On 09/24/2013 02:47 PM, Marc-André Lureau wrote:
> > I don't see why the fallback method should be the default.
> >
> > glCopyTexImage2D and glCopyPixels are equally broken with current Intel
> > mesa/drivers (I'll be filing a bug). But sw rendering is correct.
> > ---
> >   common/glc.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/glc.c b/common/glc.c
> > index 91b295c..c1795de 100644
> > --- a/common/glc.c
> > +++ b/common/glc.c
> > @@ -1263,7 +1263,7 @@ void glc_copy_pixels(GLCCtx glc, int x_dest, int
> > y_dest, int x_src, int y_src, i
> >       int recreate = 0;
> >   
> >       spice_assert(ctx);
> > -#ifdef USE_COPY_PIXELS
> > +#if 1 /* USE_COPY_PIXELS */
> 
> Why not kill the deadcode?

Well, it's not dead, it's actually working. It is more like an alternative implementation. So that's fine to keep imho.