[Spice-devel] [PATCH spice-gtk 11/14] usb: call win_usb_driver_new() during initable_init()

[Marc-André Lureau]

On Wed, Apr 23, 2014 at 11:29 PM, Jonathon Jongsma <jjongsma at redhat.com>wrote:

> unrelated format changes...
>
> ok, moved

>
> >  {
> >      SpiceUsbDeviceManager *self;
> >      SpiceUsbDeviceManagerPrivate *priv;
> > @@ -260,6 +260,17 @@ static gboolean
> > spice_usb_device_manager_initable_init(GInitable  *initable,
> >      }
> >
> >  #ifdef USE_USBREDIR
> > +
> > +#ifdef G_OS_WIN32
> > +    priv->installer = spice_win_usb_driver_new();
> > +    if (!priv->installer) {
>
>
> Am I missing something?  How can this fail?  spice_win_usb_driver_new() is
> just a simple wrapper around g_object_new()...
>

The following patches will call g_initalble_new() which can return NULL.


-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140424/10c931b6/attachment.html>