[Spice-devel] [PATCH] spice_gtk_session_sync_keyboard_modifiers() is internal

[Fabiano Fidêncio]

Hey!


On Wed, Aug 13, 2014 at 4:21 PM, Jonathon Jongsma <jjongsma at redhat.com>
wrote:

> This function was not exported, and it's not really useful as public
> API, so move the declaration to the private header.
> ---
>  gtk/spice-gtk-session-priv.h | 1 +
>  gtk/spice-gtk-session.h      | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gtk/spice-gtk-session-priv.h b/gtk/spice-gtk-session-priv.h
> index aba6fe9..48482b6 100644
> --- a/gtk/spice-gtk-session-priv.h
> +++ b/gtk/spice-gtk-session-priv.h
> @@ -25,6 +25,7 @@ G_BEGIN_DECLS
>  void spice_gtk_session_request_auto_usbredir(SpiceGtkSession *self,
>                                               gboolean state);
>  gboolean spice_gtk_session_get_read_only(SpiceGtkSession *self);
> +void spice_gtk_session_sync_keyboard_modifiers(SpiceGtkSession *self);
>
>  G_END_DECLS
>
> diff --git a/gtk/spice-gtk-session.h b/gtk/spice-gtk-session.h
> index fbcc353..3b4eac6 100644
> --- a/gtk/spice-gtk-session.h
> +++ b/gtk/spice-gtk-session.h
> @@ -59,7 +59,6 @@ GType spice_gtk_session_get_type(void);
>  SpiceGtkSession *spice_gtk_session_get(SpiceSession *session);
>  void spice_gtk_session_copy_to_guest(SpiceGtkSession *self);
>  void spice_gtk_session_paste_from_guest(SpiceGtkSession *self);
> -void spice_gtk_session_sync_keyboard_modifiers(SpiceGtkSession *self);
>
>  G_END_DECLS
>
> --
> 1.9.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>


Once we are not exposing the function, what about adding a G_GNUC_INTERNAL
in the function declaration? (in the .c file)

ACK with this change.
-- 
Fabiano Fidêncio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140813/bab39135/attachment.html>