[Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

[Cody Chan]

On Wed, Aug 13, 2014 at 11:13 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> On Wed, Aug 13, 2014 at 10:47:14PM +0800, Cody Chan wrote:
> > But you ACKed this:
> >
> http://lists.freedesktop.org/archives/spice-devel/2014-August/017209.html
> > and this's my final version,
> ​​
> doesn't it work?
>
 Since you said you tested this patch and it works for you, I'm trusting
> your tests, I haven't tried that code yet, but I feel comfortable enough
> to ACK it.

Christophe

​Of course, I test it ​carefully, "
​
doesn't it work?" I mean if it's ok to patch to upstream.
Any way, I gave the patch as attachment just now, and I'm so sorry for
my unskilled
work.
Thx you again, you've really encouraged me.

>  >
> >
> > On Wed, Aug 13, 2014 at 10:27 PM, Christophe Fergeau <
> cfergeau at redhat.com>
> > wrote:
> >
> > > Hi Cody,
> > >
> > > On Tue, Aug 12, 2014 at 11:40:58AM +0200, Christophe Fergeau wrote:
> > > > On Mon, Aug 11, 2014 at 07:58:44PM +0800, Cody Chan wrote:
> > > > > ​
> > > > > I submitted a patch several months ago about this issue,
> > > > > here
> > > > >
> > >
> http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html
> > > > >
> > > > > I check it again, and find that the value of
> > > > > g_key_file_to_data(keyfile,...) is always utf-8,
> > > > > for the value of g_uri_list_extract_uris() is utf8 urlencode.
> > > > >
> > > > > So the display problem is caused by vd_agent, but how it displays
> > > depends
> > > > > on the
> > > > > language of system, the following two screenshots show the
> difference:
> > > > > http://int64ago-tmp.qiniudn.com/guest-Chinese.png
> > > > > http://int64ago-tmp.qiniudn.com/guest-English.png
> > >
> > > I've tried to apply your patches to the upstream git repository, but
> > > your mailer seems to have corrupted them. Could you try to send them
> > > using git send-email, or if this is not working for you, could you use
> > > git format-patch and send them as an attachment? This would be very
> > > helpful, thanks!
> > >
> > > Christophe
> > >
> >
> >
> >
> > --
> > QSBDT0RFUiBGUk9NIFJJRVNUIE9GIENUU0VV
>
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
>


-- 
QSBDT0RFUiBGUk9NIFJJRVNUIE9GIENUU0VV
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140813/ae933fa3/attachment-0001.html>