[Spice-devel] [PATCH RFC] Add HACKING file

[Marc-André Lureau]

On Mon, Dec 8, 2014 at 4:54 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> Well, in this case, most people in this thread agreed the patch was not
> trivial. Since you felt differently about it and thought it was eligible
> to being pushed without review, I think these rules should give some
> guidelines in the future about what should be fine to push, and what is
> going to cause another complaint on spice-devel.
> I don't think anyone will complain for patches with a diffstat with less
> than 5 lines changed which match the criteria in that HACKING file. Just
> send everything else to the mailing list for review, and everything will
> be fine.

I don't think I screwed up those rules, and I don't think this rule
will change the fact that people may have a different subjective
opinion about what is trivial. You can say 5 lines is max, and believe
this arbitrary definition has no sense. Instead, the patch already
goes to 2 lists for post-review, and I would prefer people stick to
technical conversations rather than community guidelines when there is
no need for it and it doesn't noticeably improve the project for the
rest of the people outside this very tiny contributor community.


-- 
Marc-André Lureau