[Spice-devel] [PATCH RFC] Add HACKING file

[Daniel P. Berrange]

On Mon, Dec 08, 2014 at 04:25:24PM +0100, Christophe Fergeau wrote:
> On Mon, Dec 08, 2014 at 03:37:32PM +0100, Marc-André Lureau wrote:
> > So much of this is quite irrelevant to the discussion at hand about
> > unreviewed commit rule.
> 
> I know this is about a lot of stuff, libvirt HACKING fine had plenty of
> interesting things, so I thought why not keep them. I don't mind
> dropping everything :)
> 
> > In general I don't think we need that document, because we follow very
> > common participation rules. Having strict rules makes contributions
> > more difficult and that's really not what we are after at this point.
> 
> It's more about having things documented in a place easy to refer to
> than about having strict rules, but I don't feel too strongly about
> having this in a HACKING file or not.

Note that the title of the libvirt HACKING document says

   "Contributor guidelines"

not

   "Contributor rules"

They were not intended to be 100% strict rules that must be followed
on pain of death at all times. They're intended to lay out the common
case so that people have their broad expectations set at the right
level, still leave contributors/reviewers the freedom to deviate if
appropriate in particular patches/scenarios.

FWIW, we've found the HACKING file rules very useful in getting new
contributors onboard & up to speed with the projects way of working.
Long term contributors will of course have mentally interned all the
knowledge from the doc long ago

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|